Add TriggerSource parameter to mark SDK PRs as ready for review#42654
Open
Add TriggerSource parameter to mark SDK PRs as ready for review#42654
Conversation
Next Steps to Merge⌛ Please wait. Next steps to merge this PR are being evaluated by automation. ⌛Comment generated by summarize-checks workflow run. |
raych1
force-pushed
the
users/raych1/mark-pr-ready
branch
from
6d2a372 to
d3386d8
Compare
raych1
force-pushed
the
users/raych1/mark-pr-ready
branch
from
d3386d8 to
1e61306
Compare
Member
Author
|
@praveenkuttappan can you review this PR? |
When spec-gen-sdk pipeline is triggered by the release-plan-app, create the SDK pull request in 'ready for review' state instead of draft. A new 'TriggerSource' parameter (default: 'unspecified') is added to differentiate callers. Related: Azure/azure-sdk-tools#15209 Related: Azure/azure-sdk-tools#15294 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
raych1
force-pushed
the
users/raych1/mark-pr-ready
branch
from
1e61306 to
d40b136
Compare
| -PRTitle "$(PrTitle)-generated-from-$(Build.DefinitionName)-$(Build.BuildId)" | ||
| -PRBody "$(GeneratedSDKInformation) $(ReleasePlanInfo)" | ||
| -OpenAsDraft $true | ||
| -OpenAsDraft $${{ ne(parameters.TriggerSource, 'release-plan-app') }} |
Member
There was a problem hiding this comment.
Can this be a separate param? Trigger source could be agent, or it could be GitHub copilot. We shouldn't use release plan app value for comparison. A user might directly use MCP tool to run SDK generation too.
Member
Author
There was a problem hiding this comment.
I prefer combining them into one input param if possible to simplify the pipeline. The name check could be changed to like containing -release.
Whatever entries calling the generation pipeline, no matter MCP tool or release plan app, should set the 'TriggerSource' with the name ending with -release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When spec-gen-sdk pipeline is triggered by the release-plan-app, create the SDK pull request in 'ready for review' state instead of draft.
A new 'TriggerSource' parameter (default: 'unspecified') is added to differentiate callers.
Related: Azure/azure-sdk-tools#15209
Related: Azure/azure-sdk-tools#15294
Test Run:
Azure/azure-sdk-for-go#26675